[tests-only] Remove local previews tests,clean up and bump core commit id #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
remove-previews-tests
branch
from
c10a2c7 to
892d2f7
Compare
phil-davis
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
LGTM
Note: this leaves a couple of "local Behat test" infrastructure files in place:
tests/acceptance/config/behat.yml
tests/acceptance/features/bootstrap/bootstrap.php
tests/acceptance/features/bootstrap/RevaContext.php
Those will not be used by current tests/CI. IMO it is OK to leave them there - it will make it easy to add some scenarios for reva-specific behavior in future. (We have some in owncloud/ocis and I will look to see if any of those are useful to push down into reva)
|
Note: the similar OCIS PR is owncloud/ocis#2345 |
4 tasks
ishank011
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in this PR are
Part of: owncloud/ocis#2313